On Wed, Apr 29, 2020 at 07:17:06AM -0700, Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 03:11:22PM +0300, Mike Rapoport wrote: > > From: Mike Rapoport <rppt****@linux*****> > > > > The commit f47ac088c406 ("mm: memmap_init: iterate over memblock regions > > rather that check each PFN") made early_pfn_in_nid() obsolete and since > > CONFIG_NODES_SPAN_OTHER_NODES is only used to pick a stub or a real > > implementation of early_pfn_in_nid() it is also not needed anymore. > > I don't think you can quote a commit id for something that hasn't been > commited to mainline yet.i Ouch, that was one of the things I've indented to fix in v2... > Then again I would have just merged this > patch into the one that obsoleted early_pfn_in_nid anyway. I've kept these commits separate to preserve the authorship. I'll update the changelog so that it won't mention commit id. -- Sincerely yours, Mike.