#43809: Introduce struct for requirement targets
Open Date: 2022-02-08 00:24
Last Update: 2022-02-14 04:44
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43809
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43809
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-02-14 04:44 Updated by: alienvalkyrie
* Resolution Update from None to Accepted
* Details Updated
Comment:
Reply To alienvalkyrie
The alternative term I've been thinking about is "requirement evaluation context", or req_eval_context, which is a bit of a mouthful. Could be shortened to just req_context, but that sounds like it's part of the requirement; the context a requirement is defined in, rather than what it's evaluated against.
I decided to go with req_context now, as I think it's still clear enough and makes the most sense.
The attached patches depend on #43826 and #43835, the latter of which won't get merged until after S3_0 is out of code freeze.
I've also attached the S3_1 patch – the question of whether that one will get merged is still open.
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.1.0
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Currently, calls to is_req_active() (and accordingly, to are_reqs_active() and is_enabler_active()) are highly inscrutable, given the number of arguments (many of which are often NULL). More problematically, it's impossible to add new kinds of requirement targets without changing every call site (usually by adding another NULL at some spot in the call).
Solution: Add a new struct req_context which contains all of them and make aforementioned functions take a pointer to it. Individual call sites only need to set their relevant fields (by field name ~> better readability), so new fields can be added to the struct with less hassle.
Possible performance considerations:
Additional layer of indirection via pointer to req_context struct
Individual requirement targets don't need to be copied anymore when e.g. are_reqs_active() calls is_req_active()
Both of these are probably relatively minor.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43809
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43809