#43809: Introduce struct for requirement targets Open Date: 2022-02-08 00:24 Last Update: 2022-02-14 02:13 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43809 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43809 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-02-14 02:13 Updated by: alienvalkyrie Comment: Reply To cazfi Is there a particular reason this is targeted to 3.1? As I see it, the goal of the patch is to make future development easier. This is a bit big change to stable branch where it supposedly won't help anything. No particular reason, no. As I see it, the goal of the patch is to make requirement code more readable and maintainable, which would likely help with debugging a stable branch as well. But we can push it back if you think it's too risky – though I do have a functioning S3_1 version (regression tests looking good) that only needs another round of polishing. --------------------------------------------------------------------- Ticket Status: Reporter: alienvalkyrie Owner: alienvalkyrie Type: Patches Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.1.0 Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Currently, calls to is_req_active() (and accordingly, to are_reqs_active() and is_enabler_active()) are highly inscrutable, given the number of arguments (many of which are often NULL). More problematically, it's impossible to add new kinds of requirement targets without changing every call site (usually by adding another NULL at some spot in the call). Solution: Add a new struct requirement_targets which contains all of them and make aforementioned functions take a pointer to it. Individual call sites only need to set their relevant fields (by field name ~> better readability), so new fields can be added to the struct with less hassle. Possible performance considerations: Additional layer of indirection via pointer to requirement_targets struct Individual requirement targets don't need to be copied anymore when e.g. are_reqs_active() calls is_req_active() Both of these are probably relatively minor. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43809 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43809