コミット: 70a54b01693eda3c61814b05d699aba41015ac48 - qemu (git)

コミットメタ情報

• リビジョン: 70a54b01693eda3c61814b05d699aba41015ac48 (tree)
• 日時: 2022-01-19 01:42:41
• 作者: Daniel P. Berrangé <berrange@redh...>
• コミッター: Alex Bennée

ログメッセージ

ui: avoid compiler warnings from unused clipboard info variable

With latest clang 13.0.0 we get

../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable]

g_autoptr(QemuClipboardInfo) old = NULL;

The compiler can't tell that we only declared this variable in
order to get the side effect of free'ing it when out of scope.

This pattern is a little dubious for a use of g_autoptr, so
rewrite the code to avoid it.

Reviewed-by: Richard Henderson <[e-mail]>
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
Tested-by: Philippe Mathieu-Daudé <[e-mail]>
Signed-off-by: Daniel P. Berrangé <[e-mail]>
[AJB: fix merge conflict]
Signed-off-by: Alex Bennée <[e-mail]>
Message-Id: <[e-mail]>
Message-Id: <[e-mail]>

変更サマリ

• modified: ui/clipboard.c

差分

--- a/ui/clipboard.c
+++ b/ui/clipboard.c
@@ -62,13 +62,11 @@ void qemu_clipboard_update(QemuClipboardInfo *info)
         .type = QEMU_CLIPBOARD_UPDATE_INFO,
         .info = info,
     };
-    g_autoptr(QemuClipboardInfo) old = NULL;
-
     assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
 
     notifier_list_notify(&clipboard_notifiers, &notify);
 
-    old = cbinfo[info->selection];
+    qemu_clipboard_info_unref(cbinfo[info->selection]);
     cbinfo[info->selection] = qemu_clipboard_info_ref(info);
 }