コミット: 50b396be383a5c84c8142feeb8ef8ea0ecda80bd - gcc (git)

コミットメタ情報

• リビジョン: 50b396be383a5c84c8142feeb8ef8ea0ecda80bd (tree)
• 日時: 2022-11-25 17:39:56
• 作者: Yoshinori Sato <yo-satoh@sios...>
• コミッター: Yoshinori Sato

ログメッセージ

WIP: fix PLT.

Signed-off-by: Yoshinori Sato <[e-mail]>

変更サマリ

• modified: gcc/config/rx/rx-protos.h
• modified: gcc/config/rx/rx.cc
• modified: gcc/config/rx/rx.h
• modified: gcc/config/rx/rx.md

差分

--- a/gcc/config/rx/rx-protos.h
+++ b/gcc/config/rx/rx-protos.h
@@ -172,5 +172,7 @@ rx_find_use_of_reg (rtx reg, rtx_insn* insn, F stepfunc)
 #endif
 
 bool nonpic_symbol_mentioned_p (rtx x);
+rtx legitimize_pic_address (rtx orig,
+			    machine_mode mode ATTRIBUTE_UNUSED, rtx reg);
 
 #endif /* GCC_RX_PROTOS_H */

--- a/gcc/config/rx/rx.cc
+++ b/gcc/config/rx/rx.cc
@@ -143,11 +143,9 @@ rx_pid_data_operand (rtx op)
   return PID_NOT_PID;
 }
 
-rtx
-legitimize_pic_address (rtx orig, machine_mode mode ATTRIBUTE_UNUSED, rtx reg);
-
 static rtx
-rx_legitimize_address (rtx x, rtx oldx ,
+rx_legitimize_address (rtx x,
+		       rtx oldx ATTRIBUTE_UNUSED,
 		       machine_mode mode ATTRIBUTE_UNUSED)
 {
   if (flag_pic)
@@ -168,6 +166,32 @@ rx_legitimize_address (rtx x, rtx oldx ,
   return x;
 }
 
+/* Convert a non-PIC address in `orig' to a PIC address using @GOT or
+   @GOTOFF in `reg'.  */
+rtx
+legitimize_pic_address (rtx orig, machine_mode mode ATTRIBUTE_UNUSED, rtx reg)
+{
+  if (GET_CODE (orig) == LABEL_REF || GET_CODE (orig) == SYMBOL_REF)
+    {
+      if (reg == NULL_RTX)
+       reg = gen_reg_rtx (Pmode);
+
+      emit_insn (gen_symGOTOFF2reg (reg, orig));
+      crtl->uses_pic_offset_table = 1;
+      return reg;
+    }
+  else if (GET_CODE (orig) == SYMBOL_REF)
+    {
+      if (reg == NULL_RTX)
+       reg = gen_reg_rtx (Pmode);
+
+      emit_insn (gen_symGOT2reg (reg, orig));
+      crtl->uses_pic_offset_table = 1;
+      return reg;
+    }
+  return orig;
+}
+
 /* Return true if OP is a reference to an object in a small data area.  */
 
 static bool
@@ -303,44 +327,18 @@ nonpic_symbol_mentioned_p (rtx x)
   for (int i = GET_RTX_LENGTH (GET_CODE (x)) - 1; i >= 0; i--)
     {
       if (fmt[i] == 'E')
-	{
+       {
 	  for (int j = XVECLEN (x, i) - 1; j >= 0; j--)
 	    if (nonpic_symbol_mentioned_p (XVECEXP (x, i, j)))
 	      return true;
-	}
+       }
       else if (fmt[i] == 'e' && nonpic_symbol_mentioned_p (XEXP (x, i)))
-	return true;
+       return true;
     }
 
   return false;
 }
 
-/* Convert a non-PIC address in `orig' to a PIC address using @GOT or
-   @GOTOFF in `reg'.  */
-rtx
-legitimize_pic_address (rtx orig, machine_mode mode ATTRIBUTE_UNUSED, rtx reg)
-{
-  if (GET_CODE (orig) == LABEL_REF || GET_CODE (orig) == SYMBOL_REF)
-    {
-      if (reg == NULL_RTX)
-	reg = gen_reg_rtx (Pmode);
-
-      emit_insn (gen_symGOTOFF2reg (reg, orig));
-      crtl->uses_pic_offset_table = 1;
-      return reg;
-    }
-  else if (GET_CODE (orig) == SYMBOL_REF)
-    {
-      if (reg == NULL_RTX)
-	reg = gen_reg_rtx (Pmode);
-
-      emit_insn (gen_symGOT2reg (reg, orig));
-      crtl->uses_pic_offset_table = 1;
-      return reg;
-    }
-  return orig;
-}
-
 /* Returns TRUE for simple memory addresses, ie ones
    that do not involve register indirect addressing
    or pre/post increment/decrement.  */
@@ -539,8 +537,6 @@ rx_print_operand_address (FILE * file, machine_mode /*mode*/, rtx addr)
 	    fprintf (file, "#");
 	    output_addr_const (file, addr);
 	    fprintf (file, "@GOTOFF");
-	    crtl->uses_pic_offset_table = 1;
-	    printf("%s %p %d\n", __func__, &(crtl->uses_pic_offset_table), crtl->uses_pic_offset_table);
 	    return;
 	  }
       }
@@ -1016,47 +1012,6 @@ rx_print_operand (FILE * file, rtx op, int letter)
     }
 }
 
-/* Implement TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA.  */
-static bool
-rx_asm_output_addr_const_extra (FILE *file, rtx x)
-{
-  if (GET_CODE (x) == UNSPEC)
-    {
-      switch (XINT (x, 1))
-	{
-	case UNSPEC_PIC:
-	  /* GLOBAL_OFFSET_TABLE or local symbols, no suffix.  */
-	  output_addr_const (file, XVECEXP (x, 0, 0));
-	  break;
-	case UNSPEC_GOT:
-	  output_addr_const (file, XVECEXP (x, 0, 0));
-	  fputs ("@GOT", file);
-	  break;
-	case UNSPEC_GOTOFF:
-	  output_addr_const (file, XVECEXP (x, 0, 0));
-	  fputs ("@GOTOFF", file);
-	  break;
-	case UNSPEC_PLT:
-	  output_addr_const (file, XVECEXP (x, 0, 0));
-	  fputs ("@PLT", file);
-	  break;
-	case UNSPEC_GOTPLT:
-	  output_addr_const (file, XVECEXP (x, 0, 0));
-	  fputs ("@GOTPLT", file);
-	  break;
-	case UNSPEC_PCREL:
-	  output_addr_const (file, XVECEXP (x, 0, 0));
-	  fputs ("@PCREL", file);
-	  break;
-	default:
-	  return false;
-	}
-      return true;
-    }
-  else
-    return false;
-}
-
 /* Maybe convert an operand into its PID format.  */
 
 rtx
@@ -1092,7 +1047,6 @@ rx_gen_move_template (rtx * operands, bool is_movu)
   rtx          dest = operands[0];
   rtx          src  = operands[1];
 
-  printf("%s\n", __func__);
   /* Decide which extension, if any, should be given to the move instruction.  */
   switch (CONST_INT_P (src) ? GET_MODE (dest) : GET_MODE (src))
     {
@@ -1621,8 +1575,8 @@ rx_get_stack_layout (unsigned int * lowest,
 		 they can be used in the fast interrupt handler without
 		 saving them on the stack.  */
 	      || (is_fast_interrupt_func (NULL_TREE)
-		  && ! IN_RANGE (reg, 10, 13)))
 	      || (flag_pic && reg == PIC_REGNUM))
+		  && ! IN_RANGE (reg, 10, 13)))
 	{
 	  if (low == 0)
 	    low = reg;
@@ -1893,9 +1847,6 @@ rx_expand_prologue (void)
   else if (low)
     push_regs (high, low);
 
-  //  if (flag_pic && df_regs_ever_live_p (PIC_REGNUM))
-  //    emit_insn (gen_GOTaddr2picreg (const0_rtx));
-
   if (MUST_SAVE_ACC_REGISTER)
     {
       unsigned int acc_high, acc_low;
@@ -3089,8 +3040,8 @@ rx_is_legitimate_constant (machine_mode mode ATTRIBUTE_UNUSED, rtx x)
 
 	case UNSPEC:
 	  return XINT (x, 1) == UNSPEC_CONST ||
-	         XINT (x, 1) == UNSPEC_PID_ADDR ||
-	         XINT (x, 1) == UNSPEC_GOTOFF;
+		 XINT (x, 1) == UNSPEC_PID_ADDR ||
+		 XINT (x, 1) == UNSPEC_GOTOFF;
 
 	default:
 	  /* FIXME: Can this ever happen ?  */
@@ -3792,11 +3743,6 @@ int rx_legitimate_pic_operand_p(rtx x)
 	       || ! nonpic_symbol_mentioned_p (get_pool_constant (x)))));
 }
 
-static void
-rx_asm_final_postscan_insn (FILE *, rtx_insn *insn, rtx operands[], int num_rtx)
-{
-  return;
-}
 
 #undef  TARGET_NARROW_VOLATILE_BITFIELD
 #define TARGET_NARROW_VOLATILE_BITFIELD		rx_narrow_volatile_bitfield
@@ -3956,13 +3902,6 @@ rx_asm_final_postscan_insn (FILE *, rtx_insn *insn, rtx operands[], int num_rtx)
 #undef  TARGET_HAVE_SPECULATION_SAFE_VALUE
 #define TARGET_HAVE_SPECULATION_SAFE_VALUE speculation_safe_value_not_needed
 
-#undef TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA
-#define TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA rx_asm_output_addr_const_extra
-
-#undef TARGET_ASM_FINAL_POSTSCAN_INSN
-#define TARGET_ASM_FINAL_POSTSCAN_INSN rx_asm_final_postscan_insn
-
 struct gcc_target targetm = TARGET_INITIALIZER;
 
 #include "gt-rx.h"
-

--- a/gcc/config/rx/rx.h
+++ b/gcc/config/rx/rx.h
@@ -650,7 +650,7 @@ typedef unsigned int CUMULATIVE_ARGS;
 /* We can't directly access anything that contains a symbol,
    nor can we indirect via the constant pool.  */
 int rx_legitimate_pic_operand_p(rtx x);
-#define LEGITIMATE_PIC_OPERAND_P(X)				\
+#define LEGITIMATE_PIC_OPERAND_P(X)		\
   rx_legitimate_pic_operand_p (X)
 
 #define SYMBOLIC_CONST_P(X)	\

--- a/gcc/config/rx/rx.md
+++ b/gcc/config/rx/rx.md
@@ -465,15 +465,26 @@
 	(call (match_operand:QI 1 "general_operand")
 	      (match_operand:SI 2 "general_operand")))]
   ""
-  {
-    rtx dest = XEXP (operands[1], 0);
+{
+  rtx dest = XEXP (operands[1], 0);
 
-    if (! rx_call_operand (dest, Pmode))
-      dest = force_reg (Pmode, dest);
-    emit_call_insn (gen_call_value_internal (operands[0], dest));
-    DONE;
-  }
-)
+  if (flag_pic &&
+      (GET_CODE (dest) == SYMBOL_REF) && (!SYMBOL_REF_LOCAL_P (dest)))
+    {
+      if (flag_plt)
+        emit_call_insn (gen_call_value_internal_plt (operands[0], dest));
+      else
+        emit_call_insn (gen_call_value_internal_got (operands[0], dest));
+      DONE;
+    }
+  else
+    {
+      if (! rx_call_operand (dest, Pmode))
+        dest = force_reg (Pmode, dest);
+      emit_call_insn (gen_call_value_internal (operands[0], dest));
+    }
+  DONE;
+})
 
 (define_insn "call_value_internal"
   [(set (match_operand                  0 "register_operand" "=r,r")
@@ -2885,27 +2896,6 @@
    (set_attr "timings" "22")]
 )
 
-;; PIC stuff
-
-(define_expand "sym_label2reg"
-  [(set (match_operand:SI 0 "" "")
-	(const:SI (unspec:SI [(match_operand:SI 1 "" "")
-			      (const (plus:SI (match_operand:SI 2 "" "")
-					      (const_int 2)))]
-			     UNSPEC_SYMOFF)))]
-  ""
-  "")
-
-(define_expand "symPCREL_label2reg"
-  [(set (match_operand:SI 0 "" "")
-	(const:SI
-	 (unspec:SI
-	  [(const:SI (unspec:SI [(match_operand:SI 1 "" "")] UNSPEC_PCREL))
-	   (const:SI (plus:SI (match_operand:SI 2 "" "")
-			      (const_int 2)))] UNSPEC_PCREL_SYMOFF)))]
-  ""
-  "")
-
 (define_expand "sym2GOT"
   [(const (unspec [(match_operand 0 "" "")] UNSPEC_GOT))]
   ""
@@ -2920,38 +2910,19 @@
   DONE;
 })
 
-(define_expand "symGOTPLT2reg"
-  [(match_operand 0 "" "") (match_operand 1 "" "")]
-  ""
-{
-  rtx pltsym = gen_rtx_CONST (Pmode,
-			      gen_rtx_UNSPEC (Pmode,
-					      gen_rtvec (1, operands[1]),
-					      UNSPEC_GOTPLT));
-  DONE;
-})
-
 (define_expand "sym2GOTOFF"
   [(const (unspec [(match_operand 0 "" "")] UNSPEC_GOTOFF))]
   ""
   "")
 
-(define_insn "mov_from_rirb"
-  [(match_operand 0 "" "") (match_operand 1 "" "")]
-  ""
-{
-  return "mov.l\t[%0,%1],%0";
-}
-)
-
 (define_expand "symGOTOFF2reg"
   [(match_operand 0 "" "") (match_operand 1 "" "")]
   ""
 {
   rtx gotoffsym;
   rtx t = (!can_create_pseudo_p ()
-	   ? operands[0]
-	   : gen_reg_rtx (GET_MODE (operands[0])));
+          ? operands[0]
+          : gen_reg_rtx (GET_MODE (operands[0])));
 
   rtx picreg = gen_rtx_REG (Pmode, PIC_REG);
 
@@ -2963,38 +2934,51 @@
   DONE;
 })
 
-(define_expand "symPLT_label2reg"
-  [(set (match_operand:SI 0 "" "")
-	(const:SI
-	 (unspec:SI
-	  [(const:SI (unspec:SI [(match_operand:SI 1 "" "")] UNSPEC_PLT))
-	   (const:SI (plus:SI (match_operand:SI 2 "" "")
-			      (const_int 2)))] UNSPEC_PCREL_SYMOFF)))
-   ;; Even though the PIC register is not really used by the call
-   ;; sequence in which this is expanded, the PLT code assumes the PIC
-   ;; register is set, so we must not skip its initialization.  Since
-   ;; we only use this expand as part of calling sequences, and never
-   ;; to take the address of a function, this is the best point to
-   ;; insert the (use).  Using the PLT to take the address of a
-   ;; function would be wrong, not only because the PLT entry could
-   ;; then be called from a function that doesn't initialize the PIC
-   ;; register to the proper GOT, but also because pointers to the
-   ;; same function might not compare equal, should they be set by
-   ;; different shared libraries.
-   (use (reg:SI PIC_REG))]
-  ""
-  "")
-
-(define_expand "sym2PIC"
-  [(const (unspec [(match_operand:SI 0 "" "")] UNSPEC_PIC))]
+(define_insn "mov_from_rirb"
+  [(match_operand 0 "register_operand" "r") (match_operand 1 "register_operand" "r")]
   ""
-  "")
+{
+  return "mov.l\t[%0,%1],%0";
+})
 
 (define_insn "loadGOT"
   [(set (match_operand:SI 0 "register_operand" "=r")
-	(unspec:SI [(const_int 0)] UNSPEC_GOT))]
+       (unspec:SI [(const_int 0)] UNSPEC_GOT))]
   ""
 {
   return "mvfc\tpc,%0\n\tadd\t#_GLOBAL_OFFSET_TABLE_,%0";
-}
+})
+
+(define_expand "call_value_internal_got"
+  [(set (match_operand                  0 "register_operand" "=r,r")
+       (call (mem:QI (match_operand:SI 1 "rx_call_operand"   "r,CALL_OP_SYMBOL_REF"))
+             (const_int 0)))
+   (clobber (reg:CC CC_REG))]
+  ""
+{
+  rtx gotoffsym;
+  rtx t = (!can_create_pseudo_p ()
+          ? operands[0]
+          : gen_reg_rtx (GET_MODE (operands[0])));
+
+  rtx picreg = gen_rtx_REG (Pmode, PIC_REG);
+
+  gotoffsym = gen_sym2GOTOFF (operands[1]);
+  emit_move_insn (t, gotoffsym);
+  emit_move_insn (operands[0], t);
+  emit_insn(gen_mov_from_rirb(operands[0], picreg));
+  emit_call_insn (gen_call_internal (operands[0]));
+  DONE;
+})
+
+(define_insn "call_value_internal_plt"
+  [(set (match_operand                  0 "register_operand" "=r")
+	(call (mem:QI (match_operand:SI 1 "rx_symbolic_call_operand" ""))
+	      (const_int 0)))
+   (use (reg:SI PIC_REG))
+   (clobber (reg:CC CC_REG))]
+  ""
+  "bsr\t%A1@PLT"
+  [(set_attr "length" "4")
+   (set_attr "timings" "33")]
 )