external-busybox

Fork

mktemp: go back to using mktemp() for mktemp -u

The -u option to mktemp(1) is inherently unsafe, and the fact it exists
in the first place is probably a mistake. That said, it exists, and if
we want to support it, we should try to minimize the risk of using it.

The current code attempts to work around a build failure caused by
passing --fatal-warnings to the linker by using mkstemp() and unlinking
the resulting file, which eliminates the need for an attacker to guess
the filename (he can instead watch the temporary file directory using
inotify or some other similar mechanism). It's better instead to use
mktemp() (which at least forces the attacker to guess what "XXXXXX" was
replaced with) and tell the linker to live with the warning.

Change-Id: I01e0901db39821b7d1ce06145d1199ecd929e689

Don't treat link-time warnings as errors

We want to use mktemp(3) in the mktemp applet (it's unsafe, but so is
that particular option of the applet, and mktemp() is the least unsafe
way of implementing that option), but forcing the linker to error out on
warnings breaks the build in this case.

Change-Id: I6e976e9b467d2241be4bb0f3628991d098c492f0

awk: Fix handling of functions with empty body

ammend b79a0fef99627c457548e804fcd6e162b116cbe8 to properly
handle functions defined in another scope.

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>

mktemp: unlink mkstemp alternative to (unsafe) dry-run option

Change-Id: I19eeca4e8a915418527630105405c4d74d542ead

volume_id: nilfs config description.

Config description for nilfs added.

No code change.

Signed-off-by: Sven-Göran Bergh <sgb@systemasis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

volume_id: Adopt to new config style.

Config instructions for util-linux/volume_id are moved into the
source files according to the new config feature.

No code change.

Signed-off-by: Sven-Göran Bergh <sgb@systemasis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

volume_id: Adopt to new kbuild style.

Kbuild instructions for util-linux/volume_id are moved into the
source files according to the new build feature.

No code change.

Signed-off-by: Sven-Göran Bergh <sgb@systemasis.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Whitespace fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

catv: code shrink

catv_main 250 227 -23

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Refactor catv. Move visible() from stty to libbb.

Fixes the following TODO:

stty's visible() function and catv's guts are identical. Merge them into
an appropriate libbb function.

Also makes catv behave exactly like coreutils' cat -v e.g. it'll print 'M-^I'
instead of 'M- '.

function old new delta
visible - 70 +70
do_display 431 379 -52
catv_main 306 250 -56
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 70/-108) Total: -38 bytes

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

unpackers: by users' request, print compression percentage if -v and DESKTOP

function old new delta
bbunpack 634 731 +97

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

nc: remove unnecessary "errno = 0"

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

iplink: fix build error (IFLA_VLAN_PROTOCOL defined before include)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

logread: intercept all fatal signals, not just SIGINT

function old new delta
interrupted 27 20 -7

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

nc: remove some dead code

function old new delta
readwrite 887 841 -46

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

nc: exit when both stdin and network are closed.

function old new delta
nc_main 1051 1042 -9
readwrite 943 887 -56

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

nc: use symbolic SHUT_WR instead of literal 1

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Update docs/tcp.txt

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

buildsys: Add helper to list suid applets

Add a helper script that lists all applets that
- do or may require SUID provileges (busybox.cfg.suid)
- do not require SUID provileges (busybox.cfg.nosuid)

Some setups prefer to build two busybox binaries, one that is suid which
contains all applets that do or may require suid privileges, and a
second one for all the rest (which drops suid). To ease splitting these
two binaries, generate a list of CONFIG_ items for the suid binary.

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>

mktemp: switch to mkstemp

The compiler warning was breaking the build due to Werror, and it's
an easy fix

Change-Id: Ic109aa017c02596e9cf0aae3c6f82d72849b90cf

Fix syscalls on 4.3's bionic

Change-Id: Ibaeaa30ce88880338cd0236791f7db4cac8289b5

Add notes about TCP programming quirks.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

date: accept 'yyyy-mm-dd HH' and 'yyyy-mm-dd' date formats

function old new delta
parse_datestr 794 885 +91

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

networking: code shrink

function old new delta
in_ether - 124 +124
hexchar2int 42 - -42
ifconfig_main 1237 1106 -131
ether_input 141 - -141
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 0/1 up/down: 124/-314) Total: -190 bytes

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

awk.tests: add test for recent large integer fix

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

sed: fix matching of newlines by $

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

unzip: survive lack of CDF on non-streaming zip files

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

awk: use "long long" as integer type, not "int"

Testcase:
awk "BEGIN{n=(2^31)-1; print n, int(n), n%1, ++n, int(n), n%1}"
2147483647 2147483647 0 2147483648 2147483648 0

(last three values weren't showing right)

function old new delta
evaluate 3444 3458 +14
fmt_num 221 230 +9

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

unzip: increase PEEK_FROM_END from 16k to 64k

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

ip link: add VLAN support

function old new delta
do_add_or_delete - 1073 +1073
get_u16 - 62 +62
static.protocols - 16 +16
do_iplink 1235 1232 -3
do_change 495 - -495
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 0/1 up/down: 1151/-498) Total: 653 bytes

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>