コミット: 4208a0d8eb2cd53d22ce4cee71ffc8102486c692 - luce (git)

A Markdown shard for the Crystal programming language

コミットメタ情報

• リビジョン: 4208a0d8eb2cd53d22ce4cee71ffc8102486c692 (tree)
• 日時: 2023-05-21 19:23:06
• 作者: supercell <stigma@disr...>
• コミッター: supercell

ログメッセージ

Don't generate heading ID when there is no content

変更サマリ

• modified: CHANGELOG.md
• modified: spec/extensions/headers_with_ids.unit
• modified: src/luce/block_syntaxes/header_with_id_syntax.cr

差分

--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,6 +33,8 @@ All notable changes to Luce will be documented in this file.
 * Add a new optional parameter `disable_setext_heading` for `BlockParser#parse_lines`,
   which is used to disable the `SetextHeaderSyntax`.
 * Add a new public getter `previous_syntax` to `BlockParser`.
+* Fix an issue with `HeaderWithIdSyntax`, do not generate heading IDs for headings
+  with no content.
 * Update GFM to 0.29.0.gfm.7
 * Update Regular Expressions to support Crystal 1.8.
 

--- a/spec/extensions/headers_with_ids.unit
+++ b/spec/extensions/headers_with_ids.unit
@@ -35,3 +35,7 @@
 <h1 id="1234">1.2.34</h1>
 <h2 id="1234-2">1.23.4</h2>
 <h2 id="1234-3">1.2.3+4</h2>
+>>> no id
+# #
+<<<
+<h1></h1>

--- a/src/luce/block_syntaxes/header_with_id_syntax.cr
+++ b/src/luce/block_syntaxes/header_with_id_syntax.cr
@@ -9,7 +9,10 @@ module Luce
   class HeaderWithIdSyntax < HeaderSyntax
     def parse(parser : BlockParser) : Node
       element = super(parser).as Element
-      element.generated_id = BlockSyntax.generate_anchor_hash(element)
+
+      unless element.children.nil?
+        element.generated_id = BlockSyntax.generate_anchor_hash(element) unless element.children.not_nil!.empty?
+      end
       element
     end
   end