[Groonga-commit] ranguba/rroonga at c80b235 [master] Support passing options as argument by Hash

アーカイブの一覧に戻る

Kouhei Sutou null+****@clear*****
Mon Apr 18 18:04:33 JST 2016


Kouhei Sutou	2016-04-18 18:04:33 +0900 (Mon, 18 Apr 2016)

  New Revision: c80b2354342ad7b789c0d268f86ad4ef38c5b441
  https://github.com/ranguba/rroonga/commit/c80b2354342ad7b789c0d268f86ad4ef38c5b441

  Message:
    Support passing options as argument by Hash

  Modified files:
    ext/groonga/rb-grn-expression.c
    test/test-expression-builder.rb

  Modified: ext/groonga/rb-grn-expression.c (+0 -8)
===================================================================
--- ext/groonga/rb-grn-expression.c    2016-04-18 17:59:37 +0900 (f118d5d)
+++ ext/groonga/rb-grn-expression.c    2016-04-18 18:04:33 +0900 (c36d4c1)
@@ -203,8 +203,6 @@ rb_grn_expression_define_variable (int argc, VALUE *argv, VALUE self)
     return rb_variable;
 }
 
-/* TODO: Enable when Groonga 6.0.1 is released. */
-/*
 typedef struct
 {
     grn_ctx *context;
@@ -238,7 +236,6 @@ rb_grn_hash_from_ruby_hash_body (VALUE rb_key,
 
     return ST_CONTINUE;
 }
-*/
 
 /*
  * _object_ を追加し、 _n_arguments_ 個の引数を取る _operation_ を追加する。
@@ -269,8 +266,6 @@ rb_grn_expression_append_object (int argc, VALUE *argv, VALUE self)
                                   NULL, NULL,
                                   NULL, NULL, NULL);
 
-    /* TODO: Enable when Groonga 6.0.1 is released. */
-    /*
     if (RB_TYPE_P(rb_object, RUBY_T_HASH)) {
         RbGrnHashFromRubyHashData data;
         data.context = context;
@@ -288,13 +283,10 @@ rb_grn_expression_append_object (int argc, VALUE *argv, VALUE self)
         grn_expr_append_obj(context, expression, (grn_obj *)(data.hash),
                             operation, n_arguments);
     } else {
-    */
         object = RVAL2GRNOBJECT(rb_object, &context);
         grn_expr_append_obj(context, expression, object,
                             operation, n_arguments);
-    /*
     }
-    */
     rb_grn_context_check(context, self);
     rb_ary_push(rb_iv_get(self, "@objects"), rb_object);
 

  Modified: test/test-expression-builder.rb (+0 -1)
===================================================================
--- test/test-expression-builder.rb    2016-04-18 17:59:37 +0900 (7bc961d)
+++ test/test-expression-builder.rb    2016-04-18 18:04:33 +0900 (f4a0e4a)
@@ -688,7 +688,6 @@ EOC
       end
 
       def test_search
-        omit("TODO: Enable me when Groonga 6.0.1 is released.")
         result =****@tags***** do |record|
           record.key.fuzzy_search("Toym", :with_transposition => true)
         end
-------------- next part --------------
HTML����������������������������...
ダウンロード 



More information about the Groonga-commit mailing list
アーカイブの一覧に戻る