Clang analyzer gives a warning about fit_nationset_to_players() (this is from S3_2):
../../../src/server/plrhand.c:2668:23: warning: Assigned value is garbage or undefined [core.uninitialized.Assign]
least_misfits = misfits[i];
^ ~~~~~~~~~~
Likely the warning is caused just by the fact that there's multiple nation_set_count() calls, and the compiler cannot know that they will always (well, at least they should) return the same value.
Clang analyzer gives a warning about fit_nationset_to_players() (this is from S3_2):
../../../src/server/plrhand.c:2668:23: warning: Assigned value is garbage or undefined [core.uninitialized.Assign] least_misfits = misfits[i]; ^ ~~~~~~~~~~Likely the warning is caused just by the fact that there's multiple nation_set_count() calls, and the compiler cannot know that they will always (well, at least they should) return the same value.