alain_bkr alain_bkr alain_bkr Reply To alain_bkr
done on 3.1 Tiny patch which adds a log_normal in case of victory or when endturn is reached. This mostly simplify filtering of logs and games in autotests.
I think I did that about a year ago, and for the very same reason (to see results in testmatic runs), so I'm a bit confused here (I'm not on freeciv development env to check anything ATM)
alain_bkr Sorry for the confusion
I first did it on 3.1 , and only realized later something alike had been done on main branch
My patch just work on S3_0 and S3_1 , and may add a little to main.
The patch I was thinking is #42618, applied to what now are S3_2 and main. Not sure if your patch works well together with that. In some cases you add a new logging before the last turn and are an addition as such, but in some cases they duplicate logging in the same situation (only reading the patches)
If we you need all this in those older branches, maybe we should first backport #42618 and then adjust this patch? So that all branches would have similar strings occurring in the same situation (for filtering purposes)
alain_bkr I agree i should not break anything ! i'll cherrypick #42618 and redo needed patches
While at this topics, i would like to add the username
- _("Game ended in victory for %s."), player_name(pplayer));
+ _("Game ended in spacerace victory for %s."), player_name(pplayer),
+ pplayer->username);
and also give usernames to AI , because in log it is mostly impossible to know that Attila is AI*2
alain_bkr memo
$ fgrep -e 'skill level' -e ' rules the' -e 'set to team' -e victory console.log Console: 'victories' has been set to "Allied victory" (ALLIED). Player 'AI*1' now has AI skill level 'Experimental'. Player AI*1 set to team Team 2. Player AI*2 set to team Team 4. Player 'AI*2' now has AI skill level 'Novice'. Player AI*3 set to team Team 3. Player 'AI*3' now has AI skill level 'Experimental'. victories + "Allied victory" (ALLIED) 3: Toshaway rules the Comanches. 3: Phillip Goldson rules the Belizeans. 3: Nnamdi Azikiwe rules the Nigerians. 3: Allied victory to the Comanches, the Belizeans.
++ command line in server team AI*1 1 (lowercase t) will show on console or gui AI*1 is in Team 2 (Uppercase T)
done on 3.1
Tiny patch which adds a log_normal in case of victory or when endturn is reached.
This mostly simplify filtering of logs and games in autotests.