Clang analyzer gives a couple of "NULL dereference" -warnings about sdl2-client gui_string.c. I don't think those are valid, as they would occur only if sizeof_font_tab and the actual length of the linked list would be out of sync and I don't see a way for that to happen. Still, that double accounting design makes no sense; we have a terminated linked list which we iterate through by counting steps to reach its assumed end. Let's refactor sizeof_font_tab out.
Clang analyzer gives a couple of "NULL dereference" -warnings about sdl2-client gui_string.c. I don't think those are valid, as they would occur only if sizeof_font_tab and the actual length of the linked list would be out of sync and I don't see a way for that to happen. Still, that double accounting design makes no sense; we have a terminated linked list which we iterate through by counting steps to reach its assumed end. Let's refactor sizeof_font_tab out.