Qt client unit move speed broken (3.0.2+ (df0e020108))
So maybe it's not just me imagining things as I've wondered how units seem to move very slowly on some builds (noticed especially on Windows, but later also on Linux), at least with Qt- and sdl2-clients.
Not sure if it's really slow movement, or just lack of intermediate frames in animation (so unit is immobile when it should be animated, and then just appears on the destination)
What has likely confused me (to think that the problem has been only in some builds) is that only manual movement seems to be slowed - if one hits 'x' to autoexplore (like I usually do when I just want to see that the build works), the unit appear in the *final* tile immediately.
(On S3_0) problems seem to start with commit b9f479f7cc8130ec3eca7af85d994b81ed4b1464 / osdn #44611, last good commit is acc0afdb78492c4934546fd5e412b968617285d8
Offending commit is supposed to be optimization only, with no functional changes -> if everything else fails (in time to get 3.0.3 release out), simply reverting that change would not bring any functional bugs back. But likely the bug is easy to spot by re-examining the patch looking specifically for the reason to this behavior.
Reply To cazfi
But likely the bug is easy to spot by re-examining the patch looking specifically for the reason to this behavior.
Took several seconds... the change in mapview_common.c changes the type of the times compared for how the animation proceeds. We used to have "double" floating point accuracy from timer_read_seconds(), but now have full seconds integer accuracy.
I did a 'git pull' in this branch somewhere between 1 week and 1 month ago. It was pre- the flag-size fix and pre- the 4th column being added to the Nations tab.
Everything seemed fine (with some bugs soon to be reported) until yesterday evening (GMT-ish). I did another 'git pull' and got the flag-size fix and the 4th Nations column, but the movement speed of units decreased to +- 1 second per hex. I fiddled with all the Options->Local-Options->Graphics everything measured in milliseconds to no avail. Playing a complete Turn (I have a lot of units at sea) takes almost 15 minutes.
I'm running Ubuntu-latest and the About text is: This is Freeciv version 3.0.2+ (df0e020108), gui-qt client. Built against Qt 5.15.3, using 5.15.3
There were some system updates to qt libraries yesterday morning which I originally suspected, but it doesn't seem to be that. Older versions of the qt client (in other git branches) all are still working as expected.