citizenshand.c doing useless work when FREECIV_DEBUG not set
../../../src/server/citizenshand.c:159:18: warning: variable 'pplayer' set but not used [-Wunused-but-set-variable!]
That's basically because pplayer would only be used in log_citizens(), which currently is defined as log_debug(), which expands to nothing when FREECIV_DEBUG is not set.
Ideally the fix would support changing log_citizens() to be something else than log_debug()
Reply To cazfi
That's a build failure on CI now. To be resolved as an emergency fix.
Fix to immediate build issues (as quickly reproduced - can't promise there isn't failing corner cases still) attached. Will push immediately.
Further adjustment, going to push that one too (to S3_1 and master).
S3_0 patch attached. That one is not for an emergency, but has the usual review period.
All branches pass all eight combinations of debug/not, ndebug/not, LOG_CITIZENS_DEBUG/not