Thanks for the patch. For the misfeature of osdn that it does not send notifications when someone just adds an attachment, please add also a comment to the ticket in the future when attaching files.
Can you make also the S3_1 version? I presume the master version does not apply there.
We need also do the network capstr bump in fc_version (client with the old enum order is not compatible with a server with the new order), but that change is not necessary to carry in the submitted patch files - often it would just make patch not to apply as other ones bump it too. Mentioning for completeness sake.
Reply To cazfi
Thanks for the patch. For the misfeature of osdn that it does not send notifications when someone just adds an attachment, please add also a comment to the ticket in the future when attaching files. Can you make also the S3_1 version? I presume the master version does not apply there.
If you're not sure how to work with multiple branches, these instructions from freeciv-dev mailing list might help: https://www.freelists.org/post/freeciv-dev/Working-with-multiple-branches-and-setups
- S3_1 version attached, to unblock S3_1-d3f work awaiting this
Move User Actions to the end of the actions enum. This is step both towards having their number unhardcoded, and more logical action order for S3_1 d3f as https://www.hostedredmine.com/issues/920376