チケット #42105

Show a (cultivate|plant|transform)_time of 0

登録: 2021-04-29 03:58 最終更新: 2021-05-31 20:01

報告者:
担当者:
チケットの種類:
状況:
完了
コンポーネント:
マイルストーン:
優先度:
5 - 中
重要度:
5 - 中
解決法:
受領
ファイル:
3

詳細

A cultivate_time, plant_time or transform_time of 0 isn't illegal. Show those values in the in game help.

チケットの履歴 (13 件中 3 件表示)

2021-04-29 03:58 更新者: kvilhaugsvik
  • 新しいチケット "Show a (cultivate|plant|transform)_time of 0" が作成されました
2021-04-29 04:24 更新者: kvilhaugsvik
  • 解決法なし から 受領 に更新されました
  • マイルストーン(未割り当て) から 2.6.5 (完了済み) に更新されました
コメント

3.0 patch applies to 2.6 too.

2021-04-29 07:31 更新者: cazfi
コメント

But it means that activity is disabled.

2021-04-29 07:51 更新者: cazfi
コメント

Reply To cazfi

But it means that activity is disabled.

..or at least what rulesets document for transform_time.

I have to check what my intention was when I reworked that stuff as part of introducing cultivate/plant. Probably meant to have ruleset loading time guard that when an activity is enabled, to remove need to check both when ever activity's legality is checked.

2021-04-29 16:39 更新者: kvilhaugsvik
コメント

Reply To cazfi

I have to check what my intention was when I reworked that stuff as part of introducing cultivate/plant.

A transform_time of 0 i legal in 2.6 too.

2021-04-29 17:17 更新者: cazfi
コメント

Reply To kvilhaugsvik

Reply To cazfi

I have to check what my intention was when I reworked that stuff as part of introducing cultivate/plant.

A transform_time of 0 i legal in 2.6 too.

But is documented not to be.

2021-04-30 14:23 更新者: cazfi
コメント

-> #42120

With my current plans this ticket (the patches) still remains relevant, even if the intent changes a bit. After a couple of dependency patches get implemented, we can remove those checks for non-zero _time as redundant.

2021-05-01 09:23 更新者: cazfi
コメント
2021-05-14 21:59 更新者: cazfi
コメント

Reply To cazfi

With my current plans this ticket (the patches) still remains relevant, even if the intent changes a bit. After a couple of dependency patches get implemented, we can remove those checks for non-zero _time as redundant.

That probably require changing only the commit message.

2021-05-31 20:01 更新者: kvilhaugsvik

編集

このチケットにコメントを追加するには、ログインが必要です » ログインする