#46414: Drop FC_..._TO_...() cast macros involving unsigned values
Open Date: 2023-01-01 19:42
Last Update: 2023-09-18 04:39
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/46414
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46414
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-09-18 04:39 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.9
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
FC_PTR_TO_UINT(), FC_UINT_TO_PTR(), FC_SIZE_TO_PTR(), and FC_PTR_TO_SIZE() all have a bug that they actually use signed intptr_t instead of unsigned uintptr_t, nor does configure.ac setup that type. While these would be easy to fix, it's even easier to just drop them. They have no current users, and we don't want new users for such legacy casting methods.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/46414
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46414