#48109: CI: mac-meson build failing (-Wtautological-pointer-compare) mapview_common.c
Open Date: 2023-05-30 10:40
Last Update: 2023-05-30 12:27
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48109
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48109
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-05-30 12:27 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
Comment:
Patch to be pushed in immediately.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 8
MileStone: 3.0.8
Component: Client common
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
mac-meson CI build is giving -Wtautological-pointer-compare:
../client/mapview_common.c:1914:7: error: comparison of nonnull parameter 'width' not equal to a null pointer is 'true' on first encounter [-Werror,-Wtautological-pointer-compare]
if (width != NULL) {
^~~~~ ~~~~
../client/mapview_common.c:90:18: note: declared 'nonnull' here
fc__attribute((nonnull(5, 6)));
^
../client/mapview_common.c:1917:7: error: comparison of nonnull parameter 'height' not equal to a null pointer is 'true' on first encounter [-Werror,-Wtautological-pointer-compare]
if (height != NULL) {
^~~~~~ ~~~~
../client/mapview_common.c:90:18: note: declared 'nonnull' here
fc__attribute((nonnull(5, 6)));
^
2 errors generated.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48109
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48109