#48069: ap_diplomat_battle() nonnull target_tile
Open Date: 2023-05-24 14:32
Last Update: 2023-05-26 23:21
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48069
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48069
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-05-26 23:21 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
Comment:
Reply To cazfi
Should probably make it nonnull, and see what further issues that reveals.
S3_1 - main were not affected, but the "nonnull attribute" part done in attached patches anyway. S3_0 patch has more comprehensive fix.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.8
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Seen on S3_0; clang analyzer gives warnings about NULL dereference with tgt_tile parameter of ap_diplomat_battle().
Should probably make it nonnull, and see what further issues that reveals.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48069
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48069