#47967: gitrev is wrong in freeciv-server -v
Open Date: 2023-04-30 00:58
Last Update: 2023-05-26 20:59
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/47967
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47967
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-05-26 20:59 Updated by: cazfi
Comment:
One should use 'git diff' to check that the changes they are about to 'git add' are what they expect (no debug code forgotten in, etc.) At least in any environment where I work, 'git diff' also shows trailing spaces as colored blocks (screenshot attached, showing couple of trailing spaces in these patches)
---------------------------------------------------------------------
Ticket Status:
Reporter: alain_bkr
Owner: cazfi
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.8
Component: Bootstrap
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
S3_1
The value return buy freeciv-server -v is an old reference (in example 164 commit behind origin/S3_1 pulled today)
$ LANG=en ./server/freeciv-server -v
Encodings: Data=UTF-8, Local=ISO-8859-1, Internal=UTF-8
Freeciv version 3.1.0-beta1+ (beta version) (modified 75200a454)
$ git log origin/S3_1...75200a454 | grep commit | wc -l
164
It seems that the values of bootstrap/generate_gitrev.sh -> ./common/fc_gitrev_gen.h are not taken into account and we have a fallback from somewhere.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/47967
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47967