#47748: set_city_production() overflows Open Date: 2023-04-02 08:45 Last Update: 2023-05-01 18:08 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/47748 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47748 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-05-01 18:08 Updated by: alain_bkr Comment: origin/S3_1 373049274 I have reproducible error directly at load time from Sz4-Ai001-Lm62-230409_184438-T00069-auto.sav.xz 3: Savegame: 'ysize' has been set to 72. 3: Erminaz has been added as Cheating level AI-controlled player (classic). ../../common/city.c:2872:21: runtime error: signed integer overflow: -999999992 * 100 cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../common/city.c:2872:21 in ../../common/city.c:2879:25: runtime error: signed integer overflow: -999999997 * 100 cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../common/city.c:2879:25 in ../../common/city.c:2886:37: runtime error: signed integer overflow: -999999992 * 100 cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../common/city.c:2886:37 in Console: 'savename' has been set to "reSz4-Ai001-Lm62-230409_184438-T%04T-%R". Console: 'endturn' has been set to 69. Game saved as reSz4-Ai001-Lm62-230409_184438-T0069-manual.sav.xz Starting game. ------------------------------------------------------------------------------ All options with non-default values ------------------------------------------------------------------------------ In the column '##' the status of --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: (None) Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: From https://osdn.net/projects/freeciv/ticket/46286#comment:12505:46286:1679918727 reported by alain_bkr: 17 ../../common/city.c:2872:21: runtime error: signed integer overflow 17 ../../common/city.c:2879:25: runtime error: signed integer overflow 17 ../../common/city.c:2886:37: runtime error: signed integer overflow 4 ../../common/city.c:3156:33: runtime error: signed integer overflow The last one might be unrelated to the others. This was with S3_1. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/47748 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47748