#48152: Savegame load: assertion 'really_gives_vision(pplayer, pplayer2)' failed
Open Date: 2023-06-03 05:58
Last Update: 2023-06-10 11:55
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48152
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48152
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-06-10 11:55 Updated by: cazfi
* Priority Update from 6 to 5 - Medium
Comment:
Reply To cazfi
One place where remove_shared_vision() might get called for teamed players is after this reversed alliance check:
{{{
/* A spaceship victory is always one single player's or team's victory */
if (aplayer->spaceship.state == SSHIP_LAUNCHED
&& adv->dipl.spacerace_leader == aplayer
&& pplayers_allied(pplayer, aplayer)) {
}}}
Misread that part. 1) This particular block was about cancelling the alliance, so the players indeed should be allied to begin with. 2) Teams are checked earlier already (and "continue;")
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.0.8
Component: AI
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Loading savegame from #47493 to S3_0 (+ local patches, still needs to confirm with pure S3_0) gives "assertion 'really_gives_vision(pplayer, pplayer2)' failed."
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48152
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48152