#48127: Savegame: "unused entry" warnings about treaty.accept
Open Date: 2023-06-01 03:45
Last Update: 2023-06-06 23:12
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48127
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48127
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-06-06 23:12 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.8
Component: Server
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
Seen & investigated on S3_0: Loading a savegame sometimes gives "unused entry" warnings about "accept0" and "accept1" entries of treaties.
The treaties in question seem to be ones with no clauses added (or the clauses removed). The bug seems to be that "accept0" and "accept1" are read *inside the loop of reading clauses*. I guess that in most cases this results in multiple checks of treaty acceptance (once for each clause), but in case of zero clauses it's not checked at all.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48127
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48127