#47580: FAIR ../server/generator/mapgen.c::3102]: assertion 'pftile2 != NULL' failed.
Open Date: 2023-03-15 12:08
Last Update: 2023-06-03 10:08
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/47580
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47580
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-06-03 10:08 Updated by: cazfi
Comment:
Reply To alain_bkr
The patch works nicely , i had several exit, but no more loops of error messages.
This still needs to be reworked to a solution that can be pushed in to the repository. Can't use fc_assert_exit()
- Server should not die completely, but to return to map generation loop at srv_ready() where it might retry with another seed
- Solution should not rely on asserts being enabled -> we want also non-debug builds to work
---------------------------------------------------------------------
Ticket Status:
Reporter: alain_bkr
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.0.8
Component: Server
Severity: 9 - Highest
Resolution: None
---------------------------------------------------------------------
Ticket details:
3.0.6+ , compiled with clang14
I scripted randoms tests
I got this error at map generation time
2: Leopoldo II rules the Florentines.
2: Aditayaraj rules the Mons.
2: Antoine le Bon rules the Lorrains.
2: Creating a map of size 72 x 216 = 15552 tiles (16000 requested).
1: in fair_map_island_new() [../../../server/generator/mapgen.c::3088]: assertion '!fair_map_tile_border(pisland, pftile, sea_around_island)' failed.
2: Backtrace:
2: 0: ../../build/server/freeciv-server(backtrace_print+0x30) [0x55f399a2e390]
2: 1: ../../build/server/freeciv-server(do_log+0xe3) [0x55f399a39293]
2: 2: ../../build/server/freeciv-server(fc_assert_fail+0x94) [0x55f399a39594]
2: 3: ../../build/server/freeciv-server(+0x660aeb) [0x55f399415aeb]
2: 4: ../../build/server/freeciv-server(+0x64d4a5) [0x55f3994024a5]
2: 5: ../../build/server/freeciv-server(map_fractal_generate+0x9ef) [0x55f3993fd1af]
2: 6: ../../build/server/freeciv-server(+0x5c4f46) [0x55f399379f46]
2: 7: ../../build/server/freeciv-server(srv_main+0x33c) [0x55f399378e5c]
2: 8: ../../build/server/freeciv-server(main+0x10a6) [0x55f399369a46]
2: 9: /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7f5ed7a29d90]
2: 10: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80) [0x7f5ed7a29e40]
2: 11: ../../build/server/freeciv-server(_start+0x25) [0x55f39933ff75]
1: Please report this message at https://osdn.net/projects/freeciv/ticket/
2: Backtrace:
2: 0: ../../build/server/freeciv-server(backtrace_print+0x30) [0x55f399a2e390]
2: 1: ../../build/server/freeciv-server(do_log+0xe3) [0x55f399a39293]
2: 2: ../../build/server/freeciv-server(fc_assert_fail+0x159) [0x55f399a39659]
2: 3: ../../build/server/freeciv-server(+0x660aeb) [0x55f399415aeb]
2: 4: ../../build/server/freeciv-server(+0x64d4a5) [0x55f3994024a5]
2: 5: ../../build/server/freeciv-server(map_fractal_generate+0x9ef) [0x55f3993fd1af]
2: 6: ../../build/server/freeciv-server(+0x5c4f46) [0x55f399379f46]
2: 7: ../../build/server/freeciv-server(srv_main+0x33c) [0x55f399378e5c]
2: 8: ../../build/server/freeciv-server(main+0x10a6) [0x55f399369a46]
2: 9: /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7f5ed7a29d90]
2: 10: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80) [0x7f5ed7a29e40]
2: 11: ../../build/server/freeciv-server(_start+0x25) [0x55f39933ff75]
1: in fair_map_island_new() [../../../server/generator/mapgen.c::3102]: assertion 'pftile2 != NULL' failed.
Nicely the script saves the loaded random parameters before start, so i have a saved game to reproduce the error
##### MAP #####
set topology WRAPY|ISO
set landmass 65
set size 16
set generator FAIR
set aifill 26
I attached the generated .serv file (note the end save / start) , and the saved "game" which gives the error 100% of time here.
it was launched with
LANG=en ../../build/server/freeciv-server -p $(shuf -i 32769-59999 -n 1) -l serv.log -r fc-20230315-103711.881003025.serv 2>&1 |tee console.log
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/47580
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47580