#46404: qt: city_dialog::(next|prev)_city() buggy Open Date: 2022-12-31 18:07 Last Update: 2022-12-31 18:07 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/46404 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46404 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-12-31 18:07 Updated by: cazfi * New Ticket "qt: city_dialog::(next|prev)_city() buggy" created --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: 3.0.6 Component: Qt-client Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: S3_0 Qt-client city_dialog::next_city() and city_dialog::prev_city() may even crash if the player has no cities (presumably one should have no city dialog to click next/prev from when that's the case, but with unlucky timing it's possible) - City list size is against exactly 1 (meaning that the open city dialog is about the only city), not catching the empty city list case - The next city is assigned in a meaningless loop, that just overwrites previous round result until it reach the city list size -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/46404 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46404