#45603: Stop saving "game.hardcoded_counters"
Open Date: 2022-09-08 01:21
Last Update: 2022-09-25 01:42
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45603
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45603
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-09-25 01:42 Updated by: lachu
Comment:
Reply To cazfi
Reply To lachu
I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.
Right, There wasn't. That actually was how I encountered the problem - I got the "unused entry" warning as the entry is never loaded. So; we need to stop saving the field to new savegames (your patch already did that) and to silence the warning with secfile_entry_lookup() while loading those savegames where it was saved to.
0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch(1KB)
Change from secfile_load_bool into secfile_load_entry
This should work as expected.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: S3_2 d3f
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Counters are no longer hardcoded, so we should not save "game.hardcoded_counters" any more and especially not as TRUE!
The "unused entry" warning should be silenced from dev savegames (in "< 3019300" block of compat_load_dev() )
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45603
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45603