#45692: S3_0 legacysave.c: base_order handling issue Open Date: 2022-09-23 12:34 Last Update: 2022-09-23 12:34 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45692 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45692 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-09-23 12:34 Updated by: cazfi * New Ticket "S3_0 legacysave.c: base_order handling issue" created --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: (None) Component: Server Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Clang analyzer warns about dead assignment "order_base = base_orderbase;" on S3_0 legacysave.c:1619. Haven't looked closely, but seems to me that there's a real bug in there that it's not used, but the original 'base' gets used (so the base_order gets ignored) -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45692 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45692