#45597: AI: Refactor defender selection not to depend on wall consideration Open Date: 2022-09-06 19:16 Last Update: 2022-09-23 07:50 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45597 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45597 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-09-23 07:50 Updated by: cazfi * Status Update from Open to Closed * Resolution Update from Accepted to Fixed --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Patches Status: Closed Priority: 5 - Medium MileStone: 3.0.4 Component: AI Severity: 5 - Medium Resolution: Fixed --------------------------------------------------------------------- Ticket details: There's a dormant bug in military_advisor_choose_build() that also the latter-than-first defender unit selection is within the "if (build_walls)". It has not been causing trouble as build_walls has always been TRUE, except when there's already a suitable first-defender chosen. (So maybe it's on purpose, just with badly named gatekeeper variable) This is one of the things causing trouble in attempts to solve #45276. While the refactoring could be done as part of #45276, I'd rather do it separately first, to keep steps small and well independently tested. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45597 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45597