#45567: generate_packets.py: Support for opposite of handle-via-packet
Open Date: 2022-09-04 06:25
Last Update: 2022-09-04 13:22
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45567
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45567
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-09-04 13:22 Updated by: alienvalkyrie
Comment:
Reply To cazfi
If this feature already exist
It doesn't.
It would probably be sensible to do away with the whole "implicit handle-via-packet for ruleset packets and packets with more than five fields" anyway and instead always set it explicitly in the packets definition – would have to decide whether handle-via-packet or handle-via-args should be the default; I'll see what's more common atm.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: (None)
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
If this feature already exist, it's not obvious from documentation in packets.def.
Sometimes it's annoying in development when you add a parameter to a packet, temporarily, for debugging purposes, and suddenly the handle function prototype changes (as parameter count goes over 5). Then you have to adjust all the code for that, and your two-line debug test comes much bigger diff to handle. For these cases it would be handy if one could tell generate_packets.py to just add new parameter to the handle -function despite their count going over 5.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45567
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45567