#45735: upgrade_unit_order_targets(): Dead assignment of tgt_tile
Open Date: 2022-09-27 06:08
Last Update: 2022-10-01 13:17
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45735
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45735
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-01 13:17 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.1.0
Component: Server
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
upgrade_unit_order_targets():
/* The target is already specified in the new format. */
tgt_tile = index_to_tile(&(wld.map), order->target);
fc_assert(tgt_tile != NULL);
return;
tgt_tile is not used in NDEBUG build, and entire index_to_tile() call (with no relevant side-effect) is unnecessary in such cases.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45735
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45735