#44785: Qt citydlg.cpp: Unused but_menu_worklist
Open Date: 2022-06-09 03:01
Last Update: 2022-06-09 03:20
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44785
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44785
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-09 03:20 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
Comment:
There's no use for any of the functionality of but_menu_worklist, as the gui has better methods to achieve the same (I guess those have replaced but_menu_worklist, but it was not properly cleaned out in the process)
Will push S3_0 version also to S2_6
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.3
Component: Qt-client
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
This showed up as a S3_0 memory leak; but_menu_worklist created in Qt-client's citydlg.cpp:1746 is never deleted. The reason it's not automatically deleted with its parent is that there's no parent set to it -> seems to me it's not actually used at all, despite being maintained to some extend. Also delete_prod() exist only for this button.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44785
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44785