#44765: generate_packets.py: remove Variant members only needed on Packets
Open Date: 2022-06-06 19:57
Last Update: 2022-06-06 22:16
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44765
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44765
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-06 22:16 Updated by: alienvalkyrie
* Resolution Update from None to Accepted
Comment:
Reply To alienvalkyrie
or that can be taken unmodified from the packet this is a variant of.
This patch leaves some of those fields in if they are used in a lot of places – those should be turned into properties in #44768.
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Part of #43927. Some code is unnecessarily duplicated between Packets and Variants. Remove the fields and members of the Variant class that are only used on Packets, or that can be taken unmodified from the packet this is a variant of.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44765
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44765