#43927: Clean up and modernize generate_packets.py
Open Date: 2022-02-19 14:17
Last Update: 2022-06-06 20:34
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43927
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43927
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-06 20:34 Updated by: alienvalkyrie
* Details Updated
Comment:
Reply To cazfi
btw. Does the order here match the order in which they should be applied?
Not universally; they're grouped thematically, but the different topics are in the order they were added. It would probably be more useful to look at the order they were actually applied, e.g. the commit history on GitHub
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Tasks
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
This is a meta-ticket for various tasks relating to making common/generate_packets.py more clean and concise. This is mostly a refactoring effort, though I expect some of these changes will make the script work in more contexts.
Apart from general code/style cleanup (which should happen at every step along the way), this includes:
general cleanup: trailing whitespace, unused imports/variables/functions, etc. #43929 #44011 #44585
use pathlib to handle file paths (in a filesystem-agnostic way) #43930 #43972
use argparse to handle command line arguments #43931 #43938 #43939
use with-blocks and context managers to cleanly manage file access #43932 #43953 #43954
use generators, list comprehensions and itertools where appropriate #44007 #44008 #44009 #44010 #44583 #44584
split large functions into smaller parts #43951 #43952
improve packets.def parsing code #44571 #44572 #44573 #44580 #44582
modernize string formatting #44574 #44575 #44576 #44577
make use of static type checkers / code analysis #44615 #44762 #44763
clean up fields and methods of classes #44761 #44764 #44765 #44768
(More to be added as they pop up.)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43927
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43927