#44730: Fix city_size limitations for units.ruleset
Open Date: 2022-05-30 21:53
Last Update: 2022-06-01 18:34
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44730
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44730
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-01 18:34 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
Comment:
Sorry if you're just about to submit updated master patch, but as I'm not counting on it, I propose that at this point we push the S3_0 / S3_1 patch also to master (and we get the review period for that running immediately), and open a new ticket about further master changes.
---------------------------------------------------------------------
Ticket Status:
Reporter: ihnatus
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.2
Component: Server
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
A split of #44703 for all active branches.
Currently, city_size is lifted from non-positive values to 1 for units having "Settlers" flag. Obviously, it should be for units that can found cities that is for long a different category. Also, for them overflow of this value should be also fitted in (now, does not fail the application but breaks helptext and produces warnings).
EDIT: Tested the case. Underflow value emulates HQ9+ "+" operator and fails the ruleset to load. Overflow value takes the lower byte that may result in 0, then the city is actually deleted after creation. If we remove the "Settlers" flag from city builders, loads any values, for negative ones the lower byte goes to helptext but the city size is 1. Server complains only on bad unit type packet values. So yes, it needs to be fixed.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44730
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44730