#45001: generate_packets.py: check for errors when sending all fields
Open Date: 2022-07-03 22:55
Last Update: 2022-07-03 23:37
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45001
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45001
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-07-03 23:37 Updated by: alienvalkyrie
* Resolution Update from None to Accepted
Comment:
Note: This patch puts simplicity of the generation code over simplicity of the generated code, producing clunky-looking code for simple fields, like
e = 0; e |= DIO_PUT(...); if (e) { log_packet_detailed("... field error detected"); }instead of the simpler
if (DIO_PUT(...)) { log_packet_detailed("... field error detected"); }This will be a trend in further patches – the advantage being that the e |= DIO_PUT(...); line can be reused in other places (such as for array elements) in the future, and the surrounding code works equally well for less-simple fields (i.e. arrays).
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Part of #43927. Follow-up to #45000. Check return values of dio_put_*() for everything that is sent and move common parts out of Field.get_put_real() into Field.get_put() or (where applicable) Variant.get_send().
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45001
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45001