#43768: gcc-12: load_ruleset_units() "use after free" warning
Open Date: 2022-02-02 14:31
Last Update: 2022-02-02 17:45
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43768
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43768
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-02-02 17:45 Updated by: cazfi
Comment:
Master is affected too.
The use of the slist pointer after it has been freed is completely wrong - it never contained information relevant for the situation. It sort of looks like copy-paste error where the name of the variable has not been updated, except with the twist that the "right variable" has never been assigned a value, either.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.1.0
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
gcc-12 development version gives a warning (error when --enable-debug -> -Werror used) in S3_1 about load_ruleset_units() use of slist pointer at line 2468 after it has been freed at line 2442.
I did a gcc-12 build of S3_0 already, and it went through fine -> this is not affecting 3.0.0 plans.
Haven't checked situation in master yet.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43768
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43768