#42600: Strict coast ships can't enter tiny island cities
Open Date: 2021-07-06 11:17
Last Update: 2021-09-25 04:03
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42600
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42600
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2021-09-25 04:03 Updated by: cazfi
Comment:
Reply To (Anonymous)
Wow that was easy. Thanks.
I was checking around and found this in movement.c, bool can_exist_at_tile(...)
...
/* UTYF_COAST_STRICT unit cannot exist in an ocean tile without access to land. */
if (utype_has_flag(utype, UTYF_COAST_STRICT)
&& !is_safe_ocean(nmap, ptile)) {
return FALSE;
}
Maybe a dumb question but would this also need a "&& !pcity" condition in there too?
I think that if there's a relevant city, the function has returned already, and execution never even reach that code.
---------------------------------------------------------------------
Ticket Status:
Reporter: lexxie9952
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 2.6.6
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Photo of a boat unit who is unable to enter a tiny island city. https://cdn.discordapp.com/attachments/358555060382203905/861719109272207380/unknown.png
blamed: map.c:is_safe_ocean() and/or the conditional logic in the 3 places in movement.c which include is_safe_ocean in a conditional logic expression
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42600
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42600
