• R/O
  • HTTP
  • SSH
  • HTTPS

shogi-server: コミット

shogi-server source


コミットメタ情報

リビジョン685d75c10971f5c13e504fef3052c30b8d3fce04 (tree)
日時2010-09-04 17:18:47
作者daigo <beatles@user...>
コミッターDaigo Moriwaki

ログメッセージ

Refactored Player#set_sente_from_str().

変更サマリ

差分

--- a/shogi_server/command.rb
+++ b/shogi_server/command.rb
@@ -543,13 +543,7 @@ module ShogiServer
543543 if (@command_name == "GAME")
544544 @player.status = "game_waiting"
545545 @player.game_name = @game_name
546- if (@my_sente_str == "+")
547- @player.sente = true
548- elsif (@my_sente_str == "-")
549- @player.sente = false
550- else
551- @player.sente = nil
552- end
546+ @player.set_sente_from_str(@my_sente_str)
553547 else # challenge
554548 @player.write_safe(sprintf("##[ERROR] can't find rival for %s\n", @game_name))
555549 @player.status = "connected"
--- a/shogi_server/player.rb
+++ b/shogi_server/player.rb
@@ -115,6 +115,16 @@ class BasicPlayer
115115 @player_id = @password = nil
116116 end
117117 end
118+
119+ def set_sente_from_str(str)
120+ case str
121+ when "+": @sente = true
122+ when "-": @sente = false
123+ else
124+ # str should be "*"
125+ @sente = nil
126+ end
127+ end
118128 end
119129
120130
--- a/test/TC_player.rb
+++ b/test/TC_player.rb
@@ -41,5 +41,11 @@ class TestPlayer < Test::Unit::TestCase
4141 assert(@p.is_human?)
4242 assert(!@p.is_computer?)
4343 end
44+
45+ def test_set_sente_from_str
46+ assert_equal true, @p.set_sente_from_str("+")
47+ assert_equal false, @p.set_sente_from_str("-")
48+ assert_nil @p.set_sente_from_str("*")
49+ end
4450 end
4551
旧リポジトリブラウザで表示