• R/O
  • HTTP
  • SSH
  • HTTPS

linux-2.4.36: コミット

2.4.36-stable kernel tree


コミットメタ情報

リビジョン7d8ee8247bc2c042fd3fff6e3b311730b7c42d5a (tree)
日時2008-09-06 20:35:24
作者Florin Malita <fmalita@gmai...>
コミッターWilly Tarreau

ログメッセージ

[PPPOE]: Missing result check in pppoe_xmit().

[backport of 2.6 commit 9bc18091a5e44a368827f539289b99788eb27d4e]

skb_clone() may fail, we should check the result.

Coverity CID: 1215.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>

変更サマリ

差分

--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -907,6 +907,9 @@ int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)
907907 * give dev_queue_xmit something it can free.
908908 */
909909 skb2 = skb_clone(skb, GFP_ATOMIC);
910+
911+ if (skb2 == NULL)
912+ goto abort;
910913 }
911914
912915 ph = (struct pppoe_hdr *) skb_push(skb2, sizeof(struct pppoe_hdr));
旧リポジトリブラウザで表示