#47850: sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog() Open Date: 2023-04-13 04:53 Last Update: 2023-04-21 19:13 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/47850 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47850 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-04-21 19:13 Updated by: cazfi * Status Update from Open to Closed * Resolution Update from Accepted to Fixed --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Closed Priority: 5 - Medium MileStone: 3.0.8 Component: SDL2-client Severity: 5 - Medium Resolution: Fixed --------------------------------------------------------------------- Ticket details: As reported by clang analyzer, S3_1 popup_hurry_production_dialog() has assignment 'pBuf = pWindow->prev;' twice so that pBuf is not used at all in between. I also think that 'pWindow->prev' cannot change between those assignments, but have not checked carefully. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/47850 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47850